Redesign infractions embed#2526
Merged
Merged
Conversation
ChrisLovering
approved these changes
Apr 10, 2023
mbaruh
added
a: frontend
wookie184
requested changes
Apr 12, 2023
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
If you timeout and then untimeout a user, it is unclear that the timeout is no longer active in the infraction listing.
I know for active timeouts it specifically says they are active, but seeing this:
still makes me think that it is active, due to the expiry.
wookie184
approved these changes
Apr 13, 2023
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Looks great! I'll let you merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigns the infractions embed to be more concise and compact.
Before:
After:
The new embeds has a row of symbols that are explained in the help embeds of the appropriate commands:
I expect more symbols to be added in the future once the DB and bot can support them, such as the reason being edited, the infraction being manually pardoned (e.g due to an appeal), and the context link leading to a modmail log.